Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add mdx-code-block around tabs; use JS example for magic comments #7307

Merged
merged 1 commit into from
May 4, 2022
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -282,6 +282,7 @@ Below, we will introduce how the magic comment system can be extended to define

You can declare custom magic comments through theme config. For example, you can register another magic comment that adds a `code-block-error-line` class name:

`````mdx-code-block
<Tabs>
<TabItem value="docusaurus.config.js">

Expand Down Expand Up @@ -325,32 +326,31 @@ module.exports = {
<TabItem value="myDoc.md">

````md
In TypeScript, types help prevent runtime errors.
In JavaScript, trying to access properties on `null` will error.

```ts
function greet(name: string) {
// This will error
console.log(name.toUpper());
// .toUpper doesn't exist on string
}
```js
const name = null;
// This will error
console.log(name.toUpperCase());
// Uncaught TypeError: Cannot read properties of null (reading 'toUpperCase')
```
````

</TabItem>

</Tabs>
`````

````mdx-code-block
<BrowserWindow>

In TypeScript, types help prevent runtime errors.
In JavaScript, trying to access properties on `null` will error.

```ts
function greet(name: string) {
// This will error
console.log(name.toUpper());
// .toUpper doesn't exist on string
}
```js
const name = null;
// This will error
console.log(name.toUpperCase());
// Uncaught TypeError: Cannot read properties of null (reading 'toUpperCase')
```

</BrowserWindow>
Expand Down