Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(content-blog): generate feed by reading build output #6454

Merged
merged 4 commits into from
Jan 26, 2022
Merged

Conversation

Josh-Cena
Copy link
Collaborator

@Josh-Cena Josh-Cena commented Jan 23, 2022

Motivation

Fix #5664
Fix #6195

Have you read the Contributing Guidelines on pull requests?

Yes

Test Plan

The build output now shows all posts' content, including those with MDX.

@Josh-Cena Josh-Cena added the pr: bug fix This PR fixes a bug in a past release. label Jan 23, 2022
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Jan 23, 2022
@netlify
Copy link

netlify bot commented Jan 23, 2022

✔️ [V2]

🔨 Explore the source changes: b789d2e

🔍 Inspect the deploy log: https://app.netlify.com/sites/docusaurus-2/deploys/61f154f5ff418b00077c78ea

😎 Browse the preview: https://deploy-preview-6454--docusaurus-2.netlify.app

@github-actions
Copy link

github-actions bot commented Jan 23, 2022

⚡️ Lighthouse report for the changes in this PR:

Category Score
🔴 Performance 47
🟢 Accessibility 100
🟢 Best practices 100
🟢 SEO 100
🟢 PWA 92

Lighthouse ran on https://deploy-preview-6454--docusaurus-2.netlify.app/

@github-actions
Copy link

github-actions bot commented Jan 23, 2022

Size Change: +5.27 kB (+1%)

Total Size: 715 kB

Filename Size Change
website/.docusaurus/globalData.json 45.1 kB +1.04 kB (+2%)
website/build/assets/css/styles.********.css 104 kB +682 B (+1%)
website/build/assets/js/main.********.js 536 kB +3.55 kB (+1%)
ℹ️ View Unchanged
Filename Size
website/build/index.html 29.8 kB

compressed-size-action

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Size Change: 0 B

Total Size: 710 kB

ℹ️ View Unchanged
Filename Size
website/.docusaurus/globalData.json 44 kB
website/build/assets/css/styles.********.css 104 kB
website/build/assets/js/main.********.js 532 kB
website/build/index.html 29.8 kB

compressed-size-action

Copy link
Collaborator

@slorber slorber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, that looks like a nice fix overall, just a few minor changes

I can confirm in Feedly it's working fine, and relative images are not displayed properly 👍

image

packages/docusaurus-plugin-content-blog/src/feed.ts Outdated Show resolved Hide resolved
packages/docusaurus-plugin-content-blog/src/feed.ts Outdated Show resolved Hide resolved
packages/docusaurus-plugin-content-blog/src/feed.ts Outdated Show resolved Hide resolved
packages/docusaurus-plugin-content-blog/src/index.ts Outdated Show resolved Hide resolved
packages/docusaurus/src/commands/build.ts Show resolved Hide resolved
@Josh-Cena Josh-Cena requested a review from slorber January 26, 2022 14:37
@slorber
Copy link
Collaborator

slorber commented Jan 26, 2022

LGTM thanks 👍

@slorber slorber merged commit 76a8d5f into main Jan 26, 2022
@slorber slorber deleted the jc/fix-mdx-feed branch January 26, 2022 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: bug fix This PR fixes a bug in a past release.
Projects
None yet
3 participants