-
-
Notifications
You must be signed in to change notification settings - Fork 8.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf(mdx-loader): cache mdx/remark compiler instances #4997
Merged
Merged
Changes from 2 commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
7e44805
(mdx-loader) only create mdx compiler once per webpack config
phryneas 00c24f4
Merge branch 'master' into fix-mdx
slorber 237d6ed
Merge branch 'main' into fix-mdx
Josh-Cena f6b95a7
type fixes
Josh-Cena f42082a
Merge branch 'main' into fix-mdx
Josh-Cena 1005f2f
Merge branch 'main' into fix-mdx
Josh-Cena d9d99fb
fix path
Josh-Cena fca06d0
Merge branch 'main' into fix-mdx
Josh-Cena 95d0e6b
Merge branch 'main' into fix-mdx
Josh-Cena 51d17c5
remove assertion
Josh-Cena b38e2a9
Merge branch 'main' into fix-mdx
Josh-Cena 4972951
Merge branch 'main' into fix-mdx
slorber cc0f233
Merge branch 'main' into fix-mdx
slorber 94d70de
docs: add missing Tab/TabItem imports
slorber 59cb140
Merge branch 'main' into fix-mdx
Josh-Cena 31ae5f1
fixup
Josh-Cena File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using
this.resourcePath
here makes me think this PR is not good enough.Our remark plugins need to be able to access current file path to check if relative image/asset links are valid etc.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apparently we may be able to access it thanks to the
transform(node,vfile)
andvfile.history[0]
: https://github.com/vfile/vfile#vfilehistoryWill see how to refactor the PR with it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I just took another look at https://github.com/mdx-js/mdx/pull/1468/files and they completely removed the
filePath: this.resourcePath
from the options object and only used it as parameter in the second argument ofcompiler.process
- so it seems to be the accepted standard way to use that instead of accessingfilePath
from the options object.