Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added onRouteUpdate in versioned_docs πŸ‘¨β€πŸ’» #3443

Closed
wants to merge 1 commit into from
Closed

Added onRouteUpdate in versioned_docs πŸ‘¨β€πŸ’» #3443

wants to merge 1 commit into from

Conversation

imabp
Copy link

@imabp imabp commented Sep 12, 2020

Issue Reference: #3399
onRouteUpdate documented and Added to version-2.0.0-alpha.63

Motivation

Excited for first time contribution to Facebook's repository.

Have you read the Contributing Guidelines on pull requests?

Yes

Test Plan

No code has been changed. But documented the life cycle events.
image

Related PRs

No

@imabp imabp requested a review from yangshun as a code owner September 12, 2020 07:29
@facebook-github-bot
Copy link
Contributor

Hi @imabp!

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file.

In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@imabp imabp closed this Sep 12, 2020
@imabp
Copy link
Author

imabp commented Sep 12, 2020

Had to close PR, because created this pull request, before signing the CLA.

@docusaurus-bot
Copy link
Contributor

Deploy preview for docusaurus-2 ready!

Built without sensitive environment variables with commit 24c94cb

https://deploy-preview-3443--docusaurus-2.netlify.app

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants