Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(website): refactor showcase components #10023

Merged
merged 19 commits into from
Apr 10, 2024
Merged

Conversation

slorber
Copy link
Collaborator

@slorber slorber commented Apr 5, 2024

Motivation

Preliminary refactor so that we can easily create a showcase plugin in #9967

Preview:
https://deploy-preview-10023--docusaurus-2.netlify.app/showcase

The goal here is to greatly simplify things that were previously quite messy, notably:

  • make use of useSyncExternalStore instead of spreading useEffect to manage the querystring
  • split components properly
  • remove react-popper dependency, heavy for little value added compared to a simple title attribute

@slorber slorber added the pr: polish This PR adds a very minor behavior improvement that users will enjoy. label Apr 5, 2024
@slorber slorber requested a review from Josh-Cena as a code owner April 5, 2024 17:56
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Apr 5, 2024
Copy link

netlify bot commented Apr 5, 2024

[V2]

Name Link
🔨 Latest commit ad90e16
🔍 Latest deploy log https://app.netlify.com/sites/docusaurus-2/deploys/661645246cc6ac0008877f35
😎 Deploy Preview https://deploy-preview-10023--docusaurus-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

github-actions bot commented Apr 5, 2024

⚡️ Lighthouse report for the deploy preview of this PR

URL Performance Accessibility Best Practices SEO PWA Report
/ 🟠 66 🟢 98 🟢 96 🟢 100 🟠 88 Report
/docs/installation 🟠 66 🟢 96 🟢 100 🟢 100 🟠 88 Report
/docs/category/getting-started 🟠 75 🟢 100 🟢 100 🟢 90 🟠 88 Report
/blog 🟠 69 🟢 100 🟢 100 🟢 90 🟠 88 Report
/blog/preparing-your-site-for-docusaurus-v3 🟠 65 🟢 96 🟢 100 🟢 100 🟠 88 Report
/blog/tags/release 🟠 70 🟢 100 🟢 100 🟠 80 🟠 88 Report
/blog/tags 🟠 77 🟢 100 🟢 100 🟢 90 🟠 88 Report

Copy link

github-actions bot commented Apr 5, 2024

Size Change: -713 B (0%)

Total Size: 1.05 MB

Filename Size Change
website/build/assets/css/styles.********.css 113 kB -1.25 kB (-1%)
website/build/assets/js/main.********.js 810 kB +533 B (0%)
ℹ️ View Unchanged
Filename Size
website/.docusaurus/globalData.json 91.2 kB
website/build/index.html 38 kB

compressed-size-action

@slorber slorber added the Argos Add this label to run UI visual regression tests. See argos.yml GH action. label Apr 9, 2024
Copy link

argos-ci bot commented Apr 9, 2024

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build Status Details Updated (UTC)
default (Inspect) 👍 Changes approved 1 changed Apr 10, 2024, 8:00 AM

@slorber slorber merged commit 964a4e4 into main Apr 10, 2024
32 checks passed
@slorber slorber deleted the slorber/showcase-refactor branch April 10, 2024 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Argos Add this label to run UI visual regression tests. See argos.yml GH action. CLA Signed Signed Facebook CLA pr: polish This PR adds a very minor behavior improvement that users will enjoy.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants