Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doc container doesn't stretch full page height any more #7018

Closed
4 of 7 tasks
Josh-Cena opened this issue Mar 26, 2022 · 1 comment · Fixed by #7025
Closed
4 of 7 tasks

Doc container doesn't stretch full page height any more #7018

Josh-Cena opened this issue Mar 26, 2022 · 1 comment · Fixed by #7025
Labels
bug An error in the Docusaurus core causing instability or issues with its execution

Comments

@Josh-Cena
Copy link
Collaborator

Have you read the Contributing Guidelines on issues?

Prerequisites

  • I'm using the latest version of Docusaurus.
  • I have tried the npm run clear or yarn clear command.
  • I have tried rm -rf node_modules yarn.lock package-lock.json and re-installing packages.
  • I have tried creating a repro with https://new.docusaurus.io.
  • I have read the console error message carefully (if applicable).

Description

After beta.18, the doc container doesn't take up the full page height any more.

Reproducible demo

No response

Steps to reproduce

  1. Initialize site
  2. Remove footer (non-critical, but makes the layout take up less height by itself)
  3. Add a doc page without much content. Make sure the sidebar is short enough as well.

Expected behavior

This is the behavior in beta.17:

image

Actual behavior

This is the behavior in beta.18:

image

You can see this in our dogfooding test as well, just not so obvious:

https://docusaurus.io/tests/docs/doc-with-another-sidebar

Your environment

No response

Self-service

  • I'd be willing to fix this bug myself.
@Josh-Cena Josh-Cena added the bug An error in the Docusaurus core causing instability or issues with its execution label Mar 26, 2022
@Josh-Cena Josh-Cena changed the title Doc container doesn't stretch full page height Doc container doesn't stretch full page height any more Mar 26, 2022
@Josh-Cena
Copy link
Collaborator Author

Bisect leads up to #6925

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An error in the Docusaurus core causing instability or issues with its execution
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant