Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Double next/prev arrow on blog post #6171

Closed
5 of 7 tasks
TheZoker opened this issue Dec 22, 2021 · 2 comments · Fixed by #6213
Closed
5 of 7 tasks

Double next/prev arrow on blog post #6171

TheZoker opened this issue Dec 22, 2021 · 2 comments · Fixed by #6213
Labels
bug An error in the Docusaurus core causing instability or issues with its execution

Comments

@TheZoker
Copy link

Have you read the Contributing Guidelines on issues?

Prerequisites

  • I'm using the latest version of Docusaurus.
  • I have tried the npm run clear or yarn clear command.
  • I have tried rm -rf node_modules yarn.lock package-lock.json and re-installing packages.
  • I have tried creating a repro with https://new.docusaurus.io.
  • I have read the console error message carefully (if applicable).

Description

In the latest release, there are two arrows on the next/prev element on the blog:
image

This can also be reproduced here:
https://docusaurus.io/blog/2021/11/21/algolia-docsearch-migration

The arrow is once inserted as HTML element and once as :after element with the content attribute.

Steps to reproduce

See above

Expected behavior

Only one arrow instead of two

Actual behavior

Two arrows

Your environment

  • Public source code:
  • Public site URL:
  • Docusaurus version used:
  • Environment name and version (e.g. Chrome 89, Node.js 16.4):
  • Operating system and version (e.g. Ubuntu 20.04.2 LTS):

Reproducible demo

No response

Self-service

  • I'd be willing to fix this bug myself.
@TheZoker TheZoker added bug An error in the Docusaurus core causing instability or issues with its execution status: needs triage This issue has not been triaged by maintainers labels Dec 22, 2021
@Josh-Cena Josh-Cena removed the status: needs triage This issue has not been triaged by maintainers label Dec 22, 2021
@Josh-Cena
Copy link
Collaborator

The fix would be easy, but it would be related to our theme designing approach. @slorber should we make DocPaginatorNavLink a generic PaginatorNavLink component, or should we just make another BlogPaginatorNavLink component? I prefer the former

@slorber
Copy link
Collaborator

slorber commented Dec 28, 2021

👍 for PaginatorNavLink

We should start to implement our own typesafe theme design system (+ storybook + Chromatic) instead of using Infima classes everywhere, and this component is a good first candidate as it is used in multiple places

See also #6116

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An error in the Docusaurus core causing instability or issues with its execution
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants