-
-
Notifications
You must be signed in to change notification settings - Fork 8.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optimize showcase images #5980
Comments
Maybe this bot https://github.com/marketplace/imgbot is what we need? |
Imgbot uses lossless compression, but @slorber wants lossy compression because we only use the images at limited sizes. It's certainly achievable, but not sure if we can do that w/ CI. Maybe with @docusaurus-bot? |
🤷♂️ Imgbot looks nice but it doesn't downscale images and I'm not sure it will soon (https://github.com/imgbot/Imgbot/issues/306) This is not a high priority, but if you have any idea how to solve this we can give it a try Not 100% related but it similarly it could also be nice to have this bot running on contributors PR to avoid Prettier errors: https://github.com/creyD/prettier_action (Prettier does not emit good logs on PR, but maybe this "reviewdog" thing can be useful too, see prettier/prettier#6885 (comment)) |
Seems like our prod site can't deploy after merging a new showcase site with a 400kb image 😅 looking for a temp solution with Netlify for now, and have some ideas to fix this more definitively but it's time-consuming to set-up. |
Hmm, we have a few other 2MB+ images... Definitely worth working on |
Showcase images are too big. CI is slower than it should.
We resize them with ideal image plugin but from time to time we should downscale them on Git too.
Tried a bit different methods already, couldn't find a perfect one but this might be a helpful command
@lex111 already provided a CLI command but it doesn't downscale, only optimize: #4901
Using a smaller base-size can help the build be faster on a cold cache due to faster image resizing with the ideal image plugin.
Ideally if we could automate this with the CI, that can be convenient.
The text was updated successfully, but these errors were encountered: