Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deduplicate npm libraries (shelljs/execa, del/mkdirp) #4455

Closed
armano2 opened this issue Mar 18, 2021 · 1 comment · Fixed by #5904
Closed

Deduplicate npm libraries (shelljs/execa, del/mkdirp) #4455

armano2 opened this issue Mar 18, 2021 · 1 comment · Fixed by #5904
Labels
proposal This issue is a proposal, usually non-trivial change

Comments

@armano2
Copy link
Contributor

armano2 commented Mar 18, 2021 •
edited
Loading

After going trough code i noticed that currently this project relies on multiple packages that essentially do same thing

should we use shelljs.exec or execa for cli commands?

should we use fs-extra or shelljs for file manupulation eg. rm, cp etc.
should we keep using libraries like: del, mkdirp?
@armano2 armano2 added status: needs triage This issue has not been triaged by maintainers closed: question This issue is a user error/misunderstanding. labels Mar 18, 2021
@armano2 armano2 changed the title Libraries: Libraries Mar 18, 2021
@slorber
Copy link
Collaborator

slorber commented Mar 18, 2021

I don't know what we should do but would be ok to have a single lib instead of many if possible.

However please don't refactor too much at once, it's hard for me to review everything and still find time to iterate on features/bugfixes

@slorber slorber changed the title Libraries Deduplicate npm libraries? Mar 18, 2021
@slorber slorber changed the title Deduplicate npm libraries? Deduplicate npm libraries? (shelljs/execa, del/mkdirp) Mar 18, 2021
@Josh-Cena Josh-Cena added proposal This issue is a proposal, usually non-trivial change and removed status: needs triage This issue has not been triaged by maintainers closed: question This issue is a user error/misunderstanding. labels Oct 30, 2021
@Josh-Cena Josh-Cena changed the title Deduplicate npm libraries? (shelljs/execa, del/mkdirp) Deduplicate npm libraries (shelljs/execa, del/mkdirp) Oct 30, 2021
@Josh-Cena Josh-Cena mentioned this issue Nov 8, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
proposal This issue is a proposal, usually non-trivial change
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor(content-docs): use shelljs instead of execa facebook/docusaurus
3 participants
@armano2 @slorber @Josh-Cena