-
-
Notifications
You must be signed in to change notification settings - Fork 8.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Be resilient to Swizzle case typos #3148
Comments
I will try work on this issue! |
Thanks, You have this error because of double VV, in addition to weird casing you have an additional letterr |
Hmm, why does nAVbaR work but not nAVVbAr? |
@slorber My pr on swizzle should be merged first to avoid conflicts I think |
This is my pr for swizzle cli #3021 |
Yes we'll merge it first
@FocalChord this is expected, there's an additional letter here. You can't swizzle a component that does not exist in the first place, but you should be able to swizzle it if letters are ok but with an incorrect case |
@slorber Hi, can we get Anshuls pull request merged in please |
will try to review it asap, but this bug has higher priority: #3199 |
merged @FocalChord |
@FocalChord are u still woking on it? |
@anshulrgoyal yes @slorber Hi, as seen in the screenshot below, I get this error now |
@FocalChord I merged the PR of @anshulrgoyal that address this issue |
🐛 Bug Report
Swizzling a comp with bad casing lead to a component swizzled with a bad name.
Webpack aliases we use for themes are case-sensitive, so we should either:
I thnk 2 and 3 are simpler options.
In any case I think it's not a very good idea to create a
theme/nAVbAR
folder, even if it's the case the user used.Related: #3135
Related test: #3147
The text was updated successfully, but these errors were encountered: