Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for multiline Markdown in GridBlock content #1171

Closed
alexkrolick opened this issue Dec 30, 2018 · 0 comments
Closed

Support for multiline Markdown in GridBlock content #1171

alexkrolick opened this issue Dec 30, 2018 · 0 comments
Labels
closed: wontfix A fix will bring significant overhead, or is out of scope (for feature requests)

Comments

@alexkrolick
Copy link
Contributor

alexkrolick commented Dec 30, 2018

🚀 Feature

(This may be a bug 🐞?)

Add support for multiline Markdown inside Block components.

The default homepage layout has lots of places where text can be included inside "Block" components that take a config object. This can be difficult to manage if the text is long or contains formatting. It seems like single lines can contain Markdown links and basic formatting, but any multiline strings are treated as code blocks (monospaced).

    const Features = () => (
      <Block layout="fourColumn">
        {[
          { 
            content: "some text", // markdown here?
            image: `${baseUrl}img/logo-large.png`,
            imageAlign: "top",
            title: "Feature One"
          },
          {
            content: "The content of my second feature",
            image: `${baseUrl}img/logo-large.png`,
            imageAlign: "top",
            title: "Feature Two"
          }
        ]}
      </Block>
    );

Alternately, accepting React nodes for content would work, because you can use the MarkdownBlock component.

Have you read the Contributing Guidelines on issues?

yes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closed: wontfix A fix will bring significant overhead, or is out of scope (for feature requests)
Projects
None yet
Development

No branches or pull requests

3 participants