refactor: semantic markup improvement, fix validation warnings (#7244)

* refactor: semantic markup improvement, fix validation warnings * change section/article a bit
facebook · Apr 26, 2022 · 67faa68 · 67faa68
1 parent f9fa212
commit 67faa68
Show file tree

Hide file tree

Showing 6 changed files with 5 additions and 9 deletions.
diff --git a/packages/docusaurus-theme-classic/src/theme/DocCardList/index.tsx b/packages/docusaurus-theme-classic/src/theme/DocCardList/index.tsx
@@ -25,12 +25,12 @@ function filterItems(items: PropSidebarItem[]): PropSidebarItem[] {
 
 export default function DocCardList({items, className}: Props): JSX.Element {
   return (
-    <div className={clsx('row', className)}>
+    <section className={clsx('row', className)}>
       {filterItems(items).map((item, index) => (
         <article key={index} className="col col--6 margin-bottom--lg">
           <DocCard key={index} item={item} />
         </article>
       ))}
-    </div>
+    </section>
   );
 }
diff --git a/packages/docusaurus-theme-classic/src/theme/DocCategoryGeneratedIndexPage/index.tsx b/packages/docusaurus-theme-classic/src/theme/DocCategoryGeneratedIndexPage/index.tsx
@@ -60,9 +60,9 @@ function DocCategoryGeneratedIndexPageContent({
             <p>{categoryGeneratedIndex.description}</p>
           )}
         </header>
-        <main className="margin-top--lg">
+        <article className="margin-top--lg">
           <DocCardList items={category.items} className={styles.list} />
-        </main>
+        </article>
         <footer className="margin-top--lg">
           <DocPaginator
             previous={categoryGeneratedIndex.navigation.previous}

diff --git a/website/docs/introduction.md b/website/docs/introduction.md
@@ -56,7 +56,6 @@ In this presentation at [Algolia Community Event](https://www.algolia.com/), [Me
     height="315"
     src="https://www.youtube.com/embed/Yhyx7otSksg"
     title="Docusaurus: Documentation Made Easy"
-    frameBorder="0"
     allow="accelerometer; autoplay; clipboard-write; encrypted-media; gyroscope; picture-in-picture"
     allowFullScreen
   />

diff --git a/website/src/pages/index.tsx b/website/src/pages/index.tsx
@@ -108,7 +108,7 @@ function TweetsSection() {
     <div className={clsx(styles.section, styles.sectionAlt)}>
       <div className="container">
         <h2 className={clsx('margin-bottom--lg', 'text--center')}>
-          Loved by many engineers
+          <Translate>Loved by many engineers</Translate>
         </h2>
         <div className={clsx('row', styles.tweetsSection)}>
           {tweetColumns.map((tweetItems, i) => (
@@ -168,7 +168,6 @@ function VideoContainer() {
               height="315"
               src="https://www.youtube.com/embed/_An9EsKPhp0"
               title="Explain Like I'm 5: Docusaurus"
-              frameBorder="0"
               allow="accelerometer; autoplay; clipboard-write; encrypted-media; gyroscope; picture-in-picture"
               allowFullScreen
               loading="lazy"

diff --git a/website/versioned_docs/version-2.0.0-beta.17/introduction.md b/website/versioned_docs/version-2.0.0-beta.17/introduction.md
@@ -56,7 +56,6 @@ In this presentation at [Algolia Community Event](https://www.algolia.com/), [Me
     height="315"
     src="https://www.youtube.com/embed/Yhyx7otSksg"
     title="Docusaurus: Documentation Made Easy"
-    frameBorder="0"
     allow="accelerometer; autoplay; clipboard-write; encrypted-media; gyroscope; picture-in-picture"
     allowFullScreen
   />

diff --git a/website/versioned_docs/version-2.0.0-beta.18/introduction.md b/website/versioned_docs/version-2.0.0-beta.18/introduction.md
@@ -56,7 +56,6 @@ In this presentation at [Algolia Community Event](https://www.algolia.com/), [Me
     height="315"
     src="https://www.youtube.com/embed/Yhyx7otSksg"
     title="Docusaurus: Documentation Made Easy"
-    frameBorder="0"
     allow="accelerometer; autoplay; clipboard-write; encrypted-media; gyroscope; picture-in-picture"
     allowFullScreen
   />