From 1fac61fcbf481887ea7412a97fb5d0fcdfe3312e Mon Sep 17 00:00:00 2001 From: Florina Pacurar Date: Fri, 28 Jul 2023 13:07:04 +0300 Subject: [PATCH] fix: chore: address minor PR feedback --- .../src/theme/SiteMetadata/index.tsx | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/packages/docusaurus-theme-classic/src/theme/SiteMetadata/index.tsx b/packages/docusaurus-theme-classic/src/theme/SiteMetadata/index.tsx index 713067a17120..409905c49048 100644 --- a/packages/docusaurus-theme-classic/src/theme/SiteMetadata/index.tsx +++ b/packages/docusaurus-theme-classic/src/theme/SiteMetadata/index.tsx @@ -28,13 +28,14 @@ function AlternateLangHeaders(): JSX.Element { } = useDocusaurusContext(); const alternatePageUtils = useAlternatePageUtils(); - const currentHtmlLang = localeConfigs[currentLocale]?.htmlLang; + const currentHtmlLang = localeConfigs[currentLocale]!.htmlLang; // HTML lang is a BCP 47 tag, but the Open Graph protocol requires // using underscores instead of dashes. // See https://ogp.me/#optional // See https://en.wikipedia.org/wiki/IETF_language_tag) - const bcp47ToLocale = (code: string): string => code.replace('-', '_'); + const bcp47ToOpenGraphLocale = (code: string): string => + code.replace('-', '_'); // Note: it is fine to use both "x-default" and "en" to target the same url // See https://www.searchviu.com/en/multiple-hreflang-tags-one-url/ @@ -60,16 +61,17 @@ function AlternateLangHeaders(): JSX.Element { hrefLang="x-default" /> - {currentHtmlLang && ( - - )} + {Object.values(localeConfigs) .filter((config) => currentHtmlLang !== config.htmlLang) .map((config) => ( ))}