Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Render deployment section #6695

Merged
merged 1 commit into from
Apr 8, 2019
Merged

Add Render deployment section #6695

merged 1 commit into from
Apr 8, 2019

Conversation

anurag
Copy link
Contributor

@anurag anurag commented Mar 20, 2019

Screenshot:

image

@facebook-github-bot
Copy link

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@anurag
Copy link
Contributor Author

anurag commented Mar 26, 2019

Additional context: Render serves over 7 million requests/day as of late March 2019.

@anurag
Copy link
Contributor Author

anurag commented Apr 8, 2019

If it helps, here's the Render deployment section on Gatsby: https://www.gatsbyjs.org/docs/deploying-to-render/

@amyrlam amyrlam self-assigned this Apr 8, 2019
petetnt
petetnt approved these changes Apr 8, 2019
View reviewed changes
Copy link
Contributor

@petetnt petetnt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@amyrlam amyrlam added this to the 3.0 milestone Apr 8, 2019
@amyrlam amyrlam merged commit a1d6aef into facebook:master Apr 8, 2019
@anurag
Copy link
Contributor Author

anurag commented Apr 8, 2019 via email

@amyrlam
Copy link
Contributor

amyrlam commented Apr 8, 2019

thanks for the PR! 💯

@anurag anurag deleted the ag/render branch April 8, 2019 23:57
This was referenced Apr 8, 2019
Merged
Closed
Closed
@lock lock bot locked and limited conversation to collaborators Apr 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@petetnt petetnt petetnt approved these changes

@amyrlam amyrlam Awaiting requested review from amyrlam

@iansu iansu Awaiting requested review from iansu

Assignees

@amyrlam amyrlam

Labels
CLA Signed tag: documentation
Projects
None yet
Milestone
3.0
Development

Successfully merging this pull request may close these issues.
4 participants
@anurag @facebook-github-bot @amyrlam @petetnt