ignore .idea folder #522
ignore .idea folder #522
Conversation
this change is requred for IntelliJ-based products because project information files are written before actual generator is invoked
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at [email protected]. Thanks! |
ghost
added
the
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
|
I wouldn't put this change in this project, as something like this is a developer-specific change which they would need to do for every project they worked on. I use Webstorm, and I have this in my |
|
Plus having an existing |
|
This is not about |
|
To be clear this change is coming from WebStorm team because of how their project generator works: #368 (comment). I’m happy to accept other exceptions and special cases from IDE product teams who want to integrate with us. |
|
Ah, I see, this is a tighter integration. I was confused as to why a |
|
Yea, I’m not 100% sure about this but I trust them to know what they’re doing. 😄 |
| @@ -171,7 +171,7 @@ function checkNodeVersion() { | |||
| // https://github.com/facebookincubator/create-react-app/pull/368#issuecomment-237875655 | |||
| function isGitHubBoilerplate(root) { | |||
There was a problem hiding this comment.
Let’s rename this to isSafeToCreateProjectIn(root).
Then add comment like
// If project only contains files generated by GH, it’s safe.
// We also special case WebStorm .idea because it integrates with CRA:
// https://github.com/facebookincubator/create-react-app/pull/368#issuecomment-243446094
|
@eliperelman I think that if there's only .idea it's ok. We are calling generator only from New Project dialog and if there's only .idea no harm would be caused on command-line too. |
|
LGTM, thanks. I’ll cut a release this week. |
|
@gaearon thank you! |
* ignore .idea folder this change is requred for IntelliJ-based products because project information files are written before actual generator is invoked * better method name and explanation
* ignore .idea folder this change is requred for IntelliJ-based products because project information files are written before actual generator is invoked * better method name and explanation
this change is requred for IntelliJ-based products because project information files are written before actual generator is invoked