Use keyword warn in eslint config
#234
Conversation
We can use the keyword `warn` for rule configuration instead of a number.
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at [email protected]. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
ghost
added
the
| // We use eslint-loader so even warnings are very visibile. | ||
| // This is why we only use "WARNING" level for potential errors, | ||
| // We use eslint-loader so even 'warn's are very visibile. | ||
| // This is why we only use "'warn'" level for potential errors, |
There was a problem hiding this comment.
Looks like some text in the comment got accidentally replaced too.
There was a problem hiding this comment.
Oh, that is correct. I will push an additional commit.
| @@ -10,14 +10,12 @@ | |||
| // Inspired by https://github.com/airbnb/javascript but less opinionated. | |||
|
|
|||
| // We use eslint-loader so even warnings are very visibile. | |||
| // This is why we only use "WARNING" level for potential errors, | |||
| // This is why we only use "WARNING'" level for potential errors, | |||
|
Thanks! |
|
Thank you! And sorry for the wrong changes. 😄 |
Fix typos in Readme changelog
We can use the keyword
warnfor rule configuration instead of a number.