From 8f98a8c409c47b759ad5997a276b98af2a18895c Mon Sep 17 00:00:00 2001 From: Max Date: Sun, 24 Jul 2016 18:52:04 +0200 Subject: [PATCH 1/2] Move setup instructions to CONTRIBUTING.md --- CONTRIBUTING.md | 12 ++++++++++++ README.md | 12 +----------- 2 files changed, 13 insertions(+), 11 deletions(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index e5b4e4f1832..aa5a646ed62 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -22,6 +22,18 @@ Please **ask first** is somebody else is already working on this or the core dev Please also provide a **test plan**, i.e. specify how you verified what you added works. +## Setting up a local copy of the repository +Clone the repo and run `npm install` in the root and the `global-cli` folder. + +Once it is done, you can modify any file locally and run `npm start` or `npm run build` just like in a generated project. +If you want to try out the end-to-end flow with the global CLI, you can do this too: + +``` +npm run create-react-app my-app +cd my-app +``` + +and then run `npm start` or `npm run build`. *Many thanks to [h5bp](https://github.com/h5bp/html5-boilerplate/blob/master/CONTRIBUTING.md) for the inspiration with this contributing guide* diff --git a/README.md b/README.md index e1b02e05f7d..70dbf1a635d 100644 --- a/README.md +++ b/README.md @@ -146,17 +146,7 @@ All of them are transient dependencies of the provided npm package. ## Contributing -Clone the repo and run `npm install` in the root and the `global-cli` folder. - -Once it is done, you can modify any file locally and run `npm start` or `npm run build` just like in a generated project. -If you want to try out the end-to-end flow with the global CLI, you can do this too: - -``` -npm run create-react-app my-app -cd my-app -``` - -and then run `npm start` or `npm run build`. +We'd love to have your helping hand on `create-react-app`! See [CONTRIBUTING.md](CONTRIBUTING.md) for more information on what we're looking for and how to get started. ## Acknowledgements From 8c3e5e092f915275ef97e2488bb5b0ed1cfc3dc0 Mon Sep 17 00:00:00 2001 From: Max Date: Sun, 24 Jul 2016 18:54:13 +0200 Subject: [PATCH 2/2] Reword setup instructions slightly --- CONTRIBUTING.md | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index aa5a646ed62..feb886b3d61 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -24,9 +24,12 @@ Please also provide a **test plan**, i.e. specify how you verified what you adde ## Setting up a local copy of the repository -Clone the repo and run `npm install` in the root and the `global-cli` folder. +1. Clone the repo with `git clone https://github.com/facebookincubator/create-react-app` + +2. Run `npm install` in the root `create-react-app` folder **and** the `create-react-app/global-cli` folder Once it is done, you can modify any file locally and run `npm start` or `npm run build` just like in a generated project. + If you want to try out the end-to-end flow with the global CLI, you can do this too: ```