-
-
Notifications
You must be signed in to change notification settings - Fork 26.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document deployment to S3 #997
Comments
I've written a blog post about deploying with S3 and CloudFront. Let me know if you'd like something added to the outputted README regarding either of these. |
Thanks for the blog post! It would be really helpful to have this link directly in the README. |
@ggregoire You can add a paragraph with that link to the User Guide in the Deployment section and link to it from README. |
To be clear there's nothing we can do in Create React App to fix an issue with Internet Explorer. We didn't write it after all 😉 But it would be great to add a link to the article to user guide. |
@gaearon @ggregoire quick PR up at: #1071 |
Fixed in #1071. |
Description
When deploying CRA apps to S3, the error document is effectively ignored by IE11. This causes all routes outside of the root route to reach IE's default 404 page. I have not yet tested this on other IE versions.
Expected behavior
If error document is set to
index.html
, the application should still display theApp.js
component when visiting<S3-route>/anything
. (Alternatively, if acustomerror.html
is set, it should display that, but doesn't.)Chrome, Firefox and Safari perform this behavior as expected.
Actual behavior
IE default 404 page.
Environment
npm ls react-scripts
: [email protected]node -v
: v5.5.0npm -v
: 3.5.3Have tested from:
Reproducible Demo
I've got an example S3 deployment set up. You'll notice that the root route works fine, but you'll get the IE 404 page with any addition to the URL.
S3 Configuration:
The bucket has an open permissions policy:
and is configured for static website hosting:
More than happy to help debug further, but I'm about out of ideas on my end.
The text was updated successfully, but these errors were encountered: