Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Proposal] : Ability to load PostCSS config file from project root directory if exists #6649

Closed
pavinthan opened this issue Mar 15, 2019 · 6 comments

Comments

@pavinthan
Copy link
Contributor

pavinthan commented Mar 15, 2019

Ability to load PostCSS config file from project root directory if exists

I believe create react app help to build awesome web pages and applications by the way developer face a lot of issues with styling their pages or applications now days more of PostCSS plugins reduce that workflows

eg:

  1. stylelint
  2. Tailwind CSS
  3. PostCSS Assets

if create react app load PostCSS config file from project root directory if exists that will allow developers to configure their own configurations to build their awesome web pages and applications.

This is most useful for who like to run yarn eject but fingers is not allow it.

@pavinthan pavinthan changed the title [Proposal] Ability to load PostCSS config file from project root directory if exists [Proposal] : Ability to load PostCSS config file from project root directory if exists Mar 15, 2019
@ratheeps
Copy link

ratheeps commented Mar 18, 2019

@pavinthan This seems like a pretty good idea. for using PostCSS plugins, I'm also facing those issues.

@pavinthan
Copy link
Contributor Author

thanks @ratheeps,

It's good to have postcss.config.js configurable, @iansu or any core team members could you please add your review about this ?

@KogulVimal
Copy link

@pavinthan, It's a good way dude. I hope it'll be more useful.

@iansu
Copy link
Contributor

iansu commented Mar 18, 2019

Adding a config file for PostCSS or any other tool (Babel, webpack, etc.) is not in line with this project's goals. We do allow PostCSS to be adjusted via the browserslist in package.json but we're not planning to allow configuration beyond that at this time.

@iansu iansu closed this as completed Mar 18, 2019
@pavinthan
Copy link
Contributor Author

pavinthan commented Mar 18, 2019

@iansu if we need to add any PostCSS plugins do we need to eject react-script?

@iansu
Copy link
Contributor

iansu commented Mar 18, 2019

Yes, that would be the case. That's also the case for Babel and webpack. The reason being we want to keep things simple for users and we only have the resources to support our primary config. If you start adding plugins there are suddenly a huge number of possible configurations and we don't have the bandwidth to support that.

We will be adding support for custom templates (as well as the existing support for custom scripts) so someone could always create a PostCSS template to use with Create React App in the future.

@lock lock bot locked and limited conversation to collaborators Mar 23, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants