-
-
Notifications
You must be signed in to change notification settings - Fork 27k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make chunking toggleable #4632
Comments
I do believe we split vendor and main bundles by default in the current webpack 4 config: |
@bugzpodder Is this going to be configurable? Looks hardcoded at the moment. Single JS & CSS file installs have been invaluable for my use case. |
@tbillington currently this is not configurable. Can you elaborate on why having an extra js file would be cause an headache? |
Sure. I work on lots of projects that involve the JS I write (wrapped in CRA) being embedded within existing plain server rendered sites managed by third parties. With the current react-scripts 1 behaviour this is super easy, I can just build the files and hand them over to the site owner without needing to know where they'll be hosted (setting package.json In short:
Can expand on this if you want but that's the gist. |
Can you tell me if the proposal in #4633 (comment) would satisfy your use case? |
@Timer That seems reasonable, though I'm certainly no expert on dynamic imports 😅 |
I don't see how #5030 closed this? I have the same issue as @tbillington where I need to supply single JS & CSS files, which there doesn't seem to be a way to do in CRA v2. #5030 just talked about how the chunks are organised, not disabling the process altogether. Am I missing something? |
Is this a bug report?
Yes
Steps to Reproduce
react-scripts
at2.0.0-next.66cc7a90
. No dynamic imports in code.Build output had no chunks:
Change
react-scripts
to2.0.0-next.3e165448
.Run Yarn, build app.
Expected Behavior
Same output structure.
Actual Behavior
Different output structure.
The change identified in the react scripts 2.0 github issue didn't mention any changes to the default build process so I'm under the assumption that this build output is a bug.
The text was updated successfully, but these errors were encountered: