-
-
Notifications
You must be signed in to change notification settings - Fork 26.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Relay Modern and Apollo out of the box #3873
Comments
Can't say much about Relay, but I haven't had to do anything special to get Apollo to work. I think using either implies a server, though, and the documentation for using |
I've also used Apollo client (version 1 and 2) with create-react-app without ejecting. Some documentation on setting it up could be helpful though. I haven't used Relay before but now I'm curious to give it a try and see if there are any issues. |
agree that apollo doesnt need any extra setup at all. Dan could you clarify what you mean by "hardcode support without a need for extra macros"? |
If Apollo works out of the box, what is #1792 about? |
That's about importing |
Do Relay Modern and Apollo compile GraphQL to the same intermediate representation? I’m just trying to understand if, by implementing this, we’d hardcode support for Apollo, or it would just be a GraphQL thing. |
I believe they are both based on and use This is based on my experience with Apollo. It's possible that Relay is completely different but I don't think that's the case. |
Did some initial research (lots of Apollo experience, none of Relay) and |
That would be great. Thanks! |
Initial PR pending for the loader at #3909 👍 |
@gaearon A minimal graphql client is the best option something like this https://github.com/kadirahq/lokka This how gatsby does it |
I think this issue can be closed now. We have support for loading |
We have a few separate issues about this but given the huge growth in GraphQL popularity over the year I think it would be sensible to hardcode support both for Apollo and Relay Modern, without a need for extra macros etc. I’m open to proposals about how this should work, and a proof of concept PR.
The text was updated successfully, but these errors were encountered: