-
-
Notifications
You must be signed in to change notification settings - Fork 26.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Travis for created apps #365
Comments
You are correct on CRA using travis: https://github.com/facebookincubator/create-react-app/blob/master/.travis.yml as an open source project. I think it would be a tad too opinionated to push a CI service on an individual as there are many other providers. Travis is awesome for open source however many tend to utilize other services due to the cost of Travis for personal projects. Just my .02 |
Yea, we won't be doing this. You can always add it yourself, and it's indeed too opinionated. Thanks for the suggestion though! |
@gaearon would be nice to put an entry in the readme on how to setup travis. Should be pretty easy |
Agree now that we have testing. |
@vjeux I like the idea of a CI section, where it could eventually show how to setup different CI services(similar to the deployment section). I'm more than happy to help with this one :) |
@Jiansen, yeah, if you want to add the note for Travis I think that it makes sense and you should take it 😄 that is more than fine with me 👍 We can worry about adding notes for other CIs when the need comes :) |
In addition to local Jest test, I think it is still useful to include
.travis.yml
in the generated app. For example, like CRA, the app could be built and tested in both Node 4 and 6 for every pushed commit.Travis is harmless for users who don't want to use it.
The text was updated successfully, but these errors were encountered: