Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend --scripts-version to support more formats #3573

Closed
SaschaDens opened this issue Dec 9, 2017 · 2 comments
Closed

Extend --scripts-version to support more formats #3573

SaschaDens opened this issue Dec 9, 2017 · 2 comments

Comments

@SaschaDens
Copy link
Contributor

For a project I want to use a custom react-scripts to provide additional tasks for code compilation.
Here I wanted to make use --scripts-version with a default generated .tar.gz file from GitLab.

But --scripts-version only looks for the .tgz extension and therefor the command fails. I was initially confused by the following line createReactApp.js#L374 but after digging in the code I found that there is only a check done for .tgz.

I can create a PR for this to further extend the checks done at createReactApp.js#L419 to also look for .tar and .tar.gz formats as the package that's used to extract the content also supports these formats (tar-pack), and also extend the documentation and console output as documentation is currently limited for --scripts-version (GIT is apparently also supported).

Would it make sense?

@gaearon
Copy link
Contributor

gaearon commented Jan 8, 2018

Yes, this sounds good.

@gaearon
Copy link
Contributor

gaearon commented Jan 15, 2018

This is out! Please let us know if something doesn’t quite work.
https://github.com/facebookincubator/create-react-app/releases/tag/v1.1.0

@lock lock bot locked and limited conversation to collaborators Jan 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants