Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port cra.sh development task to javascript #2280

Closed
ianschmitz opened this issue May 20, 2017 · 2 comments
Closed

Port cra.sh development task to javascript #2280

ianschmitz opened this issue May 20, 2017 · 2 comments

Comments

@ianschmitz
Copy link
Contributor

A quick improvement I'd thought I'd propose for those of us looking to contribute to CRA from a Windows machine.

As part of end to end testing while contributing to CRA we can use the npm run create-react-app my-app command to generate a new app. However this fails when run on Windows:

$ npm run create-react-app test

> @ create-react-app C:\Projects\create-react-app
> tasks/cra.sh "test"

'tasks' is not recognized as an internal or external command,
operable program or batch file.

A simple solution may be to port the cra.sh shell script to javascript, which would make it easier to run on a Windows based machine. There are workarounds such as installing Bash on Windows 10, but this would make life a little easier :)

I'd be happy to submit a PR if we think it's worthwhile.

@gaearon
Copy link
Contributor

gaearon commented May 20, 2017

Please do!

@ianschmitz
Copy link
Contributor Author

Closing as this issue has been aggregated over at #2855.

@lock lock bot locked and limited conversation to collaborators Jan 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants