Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a way to open files from the error box #2110

Closed
gaearon opened this issue May 10, 2017 · 4 comments · Fixed by #2150
Closed

Add a way to open files from the error box #2110

gaearon opened this issue May 10, 2017 · 4 comments · Fixed by #2150
Labels
contributions: up for grabs! difficulty: complex tag: enhancement
Milestone
1.0.0

Comments

@gaearon
Copy link
Contributor

gaearon commented May 10, 2017

We should add something like this to our devserver, and then make lines in the crash overlay call the devserver (opening the files).
@gaearon gaearon added this to the 0.11.0 milestone May 10, 2017
@gaearon
Copy link
Contributor Author

gaearon commented May 10, 2017

This is basically what RN is using: https://github.com/facebook/react-native/blob/118e981174ae513426e2f5ddd7ee3c5860519ff7/local-cli/server/middleware/openStackFrameInEditorMiddleware.js.

@gaearon gaearon mentioned this issue May 11, 2017
Merged
@Timer Timer modified the milestones: 0.10.0, 0.11.0 May 14, 2017
@Timer
Copy link
Contributor

Timer commented May 14, 2017

#2141

@Timer Timer closed this as completed May 14, 2017
@gaearon
Copy link
Contributor Author

gaearon commented May 14, 2017

We should probably add back the code that prints instructions when the editor hasn't matched. RN had code for this but I cut it out because I didn't want to test it. I'd like to keep it open until we have time to add that back in.

@gaearon gaearon reopened this May 14, 2017
@Timer
Copy link
Contributor

Timer commented May 14, 2017

Sorry, wasn't aware! 😅

@gaearon gaearon mentioned this issue May 14, 2017
Merged
@lock lock bot locked and limited conversation to collaborators Jan 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
contributions: up for grabs! difficulty: complex tag: enhancement
Projects
None yet
Milestone
1.0.0
Development

Successfully merging a pull request may close this issue.

Print error messages for editor integration gaearon/create-react-app
3 participants
@Timer @gaearon and others