Skip to content

Commit

Permalink
Dogfood our eslint config (#68)
Browse files Browse the repository at this point in the history
* dogfood eslint config

* moved linting to e2e
  • Loading branch information
keyz authored and gaearon committed Jul 22, 2016
1 parent 417f3a7 commit b1ce459
Show file tree
Hide file tree
Showing 3 changed files with 11 additions and 1 deletion.
7 changes: 7 additions & 0 deletions .eslintrc.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
const clientESLintConfig = require('./config/eslint');

module.exports = Object.assign({}, clientESLintConfig, {
env: Object.assign({}, clientESLintConfig.env, {
node: true
})
});
2 changes: 1 addition & 1 deletion scripts/eject.js
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ prompt('Are you sure you want to eject? This action is permanent. [y/N]', functi

files.forEach(function(file) {
console.log('Copying ' + file + ' to ' + hostPath);
content = fs
var content = fs
.readFileSync(path.join(selfPath, file), 'utf8')
// Remove license header from JS
.replace(/^\/\*\*(\*(?!\/)|[^*])*\*\//, '')
Expand Down
3 changes: 3 additions & 0 deletions tasks/e2e.sh
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,9 @@ perl -i -p0e 's/bundledDependencies.*?]/bundledDependencies": []/s' package.json
npm install
scripts_path=$PWD/`npm pack`

# lint
./node_modules/.bin/eslint --ignore-path .gitignore ./

# Pack CLI
cd global-cli
npm install
Expand Down

2 comments on commit b1ce459

@avindra
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dogfood? πŸ™€

@keyz
Copy link
Contributor Author

@keyz keyz commented on b1ce459 Jul 22, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please sign in to comment.