Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manifest merger failed: Duplicate package name #58

Closed
PaulWoitaschek opened this issue Jan 28, 2020 · 3 comments
Closed

Manifest merger failed: Duplicate package name #58

PaulWoitaschek opened this issue Jan 28, 2020 · 3 comments

Comments

@PaulWoitaschek
Copy link

PaulWoitaschek commented Jan 28, 2020

When adding soloader 0.8.0 my build fails with an error in the manifest merger:

[com.facebook.soloader:soloader:0.8.0] /home/ph1b/.gradle/caches/transforms-2/files-2.1/8f085a1fa1db60fbcb92924ed2143bb2/jetified-soloader-0.8.0/AndroidManifest.xml Error:
	Package name 'com.facebook.soloader' used in: com.facebook.soloader:soloader:0.8.0, com.facebook.soloader:annotation:0.8.0.
/home/ph1b/repos/SoLoaderBug/app/src/main/AndroidManifest.xml Error:
	Validation failed, exiting

This is because I followed the advise from: https://developer.android.com/studio/releases/gradle-plugin:

The correct usage of unique package names are currently not enforced but will become more strict on later versions of the plugin. On Android Gradle plugin version 3.4.0, you can opt-in to check whether your project declares acceptable package names by adding the line below to your gradle.properties file.

android.uniquePackageNames = true

It would be great if you gave the annotations artifact a proper unique package name.

@PaulWoitaschek PaulWoitaschek changed the title Manifest merger failed: Duplciate packages Manifest merger failed: Duplicate package name Jan 28, 2020
@mozarty
Copy link

mozarty commented Mar 10, 2020

+1

@junesolar
Copy link

How to fix this? I

@ZacSweers
Copy link
Contributor

The annotations artifact is a native java library, yet for some reason soloader is distributing it as an aar. Will try to fix in a proposal PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants