Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Making the modal pop up and show giphy/evil quote #30

Open
georgiamshaw opened this issue Nov 15, 2019 · 0 comments
Open

Making the modal pop up and show giphy/evil quote #30

georgiamshaw opened this issue Nov 15, 2019 · 0 comments

Comments

@georgiamshaw
Copy link

Great job so far! Feel like this is your next step in terms of getting to the MVP you wanted...

Have a look at my week 3 project, where we did a similar thing - here's the link

What we did was create a separate "quiz answer" section in our html, then we would toggle between the questions/answers and the result using a display of "none" and a display of "block".

You can see this in the screenshot below - when the answer is correct/incorrect, we change the display of the section and also make a callback to our giphy API call which returns a giphy that we can display in the pop up.
Screen Shot 2019-11-15 at 10 07 42

Also I would bear in mind that if you are planning on showing a pop up, the user won't actually see your coloured red/green buttons - so maybe don't worry about the fact that currently, a user can click on more than one button. Adding the pop up will stop them from being able to do this.

If you do really want the user to see the green/red colour, you could perhaps set a timeout to 1 second so that the user sees the colour before being sent to the pop up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant