Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fabulous nuget pacakge not listing an FSharp.Core dependency #795

Closed
dsyme opened this issue Aug 25, 2020 · 2 comments · Fixed by #797
Closed

Fabulous nuget pacakge not listing an FSharp.Core dependency #795

dsyme opened this issue Aug 25, 2020 · 2 comments · Fixed by #797

Comments

@dsyme
Copy link
Collaborator

dsyme commented Aug 25, 2020

I notice the FSHarp.Core dependency is not being listed on the Fabulous nuget package, I'm not sure why, I guess it just needs an entry in the nuspec

https://www.nuget.org/packages/Fabulous/0.57.0

@dsyme
Copy link
Collaborator Author

dsyme commented Aug 25, 2020

Also components like Fabulous.XamarinForms.FFImageLoading are listing upward bound dependencies like (>= 0.55.0-preview3) for Fabulous and Fabulous.XamarinForms.

I think this should be more like 0.55.* or just = 0.55.0-preview3 since there's no guarantee of any binary API compat between Fabulous versions at the moment.

This came up in dotnet/fsharp#9370 which was using a mix of versions of components which were assuming binary compat

@TimLariviere
Copy link
Member

TimLariviere commented Aug 25, 2020

Regarding FSharp.Core, I tried to follow the Notes and Guidance, but wasn't really sure what to do and ended up making it private.
I'll change that and pin it to 4.7.0 I guess? (it's the first targeting .NET Standard 2.0 directly)
https://github.com/fsprojects/Fabulous/blob/b75d01881c5c1c86d2989faf19dae9ce960422ba/Packages.targets#L23

For Fabulous.XamarinForms.FFImageLoading, it's a limitation of the new SDK-style projects.
NuGet automatically infers a >= constraint based on the project file when using a ProjectReference.
AFAIK there's no way to change that, except via writing an actual nuspec file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants