Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

XamarinForms extensions have no ref and shell properties #560

Closed
Happypig375 opened this issue Sep 15, 2019 · 3 comments · Fixed by #562
Closed

XamarinForms extensions have no ref and shell properties #560

Happypig375 opened this issue Sep 15, 2019 · 3 comments · Fixed by #562

Comments

@Happypig375
Copy link

See:
https://github.com/fsprojects/Fabulous/blob/13b2a75521589629da7eaf0585741232f62e450c/Fabulous.XamarinForms/extensions/OxyPlot/OxyPlot.fs#L20-L26
There are no ref nor shell* properties.
Need to update the Generator to regenerate properties for extensions when base views are updated.
@SergejDK
Copy link
Collaborator

I think the extensions are currently written per hand and not auto generated.
I think this will be different in the future.

@TimLariviere
Copy link
Member

@SergejDK is right.
The extensions are currently written by hand, so we can easily fix this issue.

@SergejDK
Copy link
Collaborator

I will fix this the next days.

@SergejDK SergejDK mentioned this issue Sep 16, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add props to Fabulous.XamarinForms Extensions
3 participants
@TimLariviere @Happypig375 @SergejDK