Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nuget.targets bug in Templates #288

Closed
jiangzhen3s opened this issue Jan 21, 2019 · 1 comment
Closed

nuget.targets bug in Templates #288

jiangzhen3s opened this issue Jan 21, 2019 · 1 comment

Comments

@jiangzhen3s
Copy link

jiangzhen3s commented Jan 21, 2019 •
edited
Loading

https://github.com/fsprojects/Fabulous/blob/master/templates/content/blank/.nuget/NuGet.targets#L53

"$(SolutionDir) "

==》 "$(SolutionDir)\"
@mallibone
Copy link

Hey @jiangzhen3s thanks for finding this one, I just stumbled over it myself. There seems to be another issue with that line that it ends with a \ which is a problem when running build.cmd Test on Windows. I hope I'll have a fix later today so we can run the build and tests on Windows.

@TimLariviere this would mean we could also adapt Azure DevOps CI to run the tests on every commit/pull request.

@mallibone mallibone mentioned this issue Jan 21, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jiangzhen3s @mallibone @TimLariviere