Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Certain hardware doesn't support WebGL precision highp fragment shader #4432

Closed
ozooner opened this issue Oct 31, 2017 · 4 comments
Closed

Comments

@ozooner
Copy link
Contributor

ozooner commented Oct 31, 2017

Version

2.0 beta

Test Case

Turns out certain hardware does not support WebGL precision highp float;
For given hardware shader with mediump or lowp works fine

Steps to reproduce

Amazon Fire TV stick Gen 2
CPU: Mediatek MT8127D 4x ARM Cortex-A7 @ 1.3 GHz
GPU: Mali 450 MP4

Expected Behavior

To render WebGL filters

Actual Behavior

screenshot_20171031_204357

@asturur
Copy link
Member

asturur commented Oct 31, 2017

oh well. how to detect that? will be mediump enough for filters? what can we really do with an amazon fire tv stick?

@ozooner
Copy link
Contributor Author

ozooner commented Oct 31, 2017

Just a second, creating PR

@ozooner
Copy link
Contributor Author

ozooner commented Oct 31, 2017

#4433

@ozooner
Copy link
Contributor Author

ozooner commented Oct 31, 2017

So in my test case, only highp isn't supported, however there could be hardware that:

  • doesn't support highp and mediump, only lowp
  • passes the webGL support test, but doesn't support any precision

So the PR takes care of these hypothetical scenarios as well

@asturur asturur closed this as completed Oct 31, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants