Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ActiveGroup has incorrect layering #2118

Closed
inssein opened this issue Apr 16, 2015 · 7 comments
Closed

ActiveGroup has incorrect layering #2118

inssein opened this issue Apr 16, 2015 · 7 comments

Comments

@inssein
Copy link
Contributor

inssein commented Apr 16, 2015

Fiddle:
https://jsfiddle.net/2zs3wy56/

If you select the orange rectangle on the left, and then shift + click orange rectangle on the right, it will properly create an active group of two, but now the third red rectangle is behind both.

This is probably because the active group is rendered in the upper canvas right?

@asturur
Copy link
Member

asturur commented Apr 16, 2015

No.
everything is rendered on main canvas more or less.
the activeGroup is rendered later and so in on top.

to do it different enable cancas.preserveObjectStacking = true.

it will then render fine.

@inssein
Copy link
Contributor Author

inssein commented Apr 16, 2015

@asturur ah I was just editing my post as I discovered the same.

That said, the fix you suggested introduces a new bug. It render's the orange rectangles in the top left.

Fiddle: https://jsfiddle.net/knr61L12/

@asturur
Copy link
Member

asturur commented Apr 16, 2015

@kangax is gonna kill me.

@inssein
Copy link
Contributor Author

inssein commented Apr 16, 2015

@asturur haha, hope not. I am available to help on this, just trying to think of what the correct fix is.

Issue: preserveObjectStacking is drawing the objects which are grouped, but its not going through transform() since the group's render() function is not called, correct?

@asturur
Copy link
Member

asturur commented Apr 16, 2015

i know what is wrong, i m gonna put it back

@inssein
Copy link
Contributor Author

inssein commented Apr 16, 2015

@asturur awesome thanks!

@asturur
Copy link
Member

asturur commented Apr 16, 2015

PR #2120 fix it.

@kangax kangax closed this as completed Apr 17, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants