Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inline SVGs aren't recognized as valid HTML elements #41

Open
respatialized opened this issue Feb 26, 2022 · 0 comments
Open

Inline SVGs aren't recognized as valid HTML elements #41

respatialized opened this issue Feb 26, 2022 · 0 comments
Assignees
Labels
bug Something isn't working
Milestone

Comments

@respatialized
Copy link
Contributor

respatialized commented Feb 26, 2022

They clearly should be, as my own website uses them frequently and they are part of the HTML spec; they are currently commented out of the list of tags for phrasing contents.

There are two ways of handling this, one expedient and the other more long-term: assume any SVG is fine regardless of its contents and let the browser's renderer attempt to display it, or incorporate a hiccup / malli schema for SVG into the html namespace and use that.

Thinking about how to handle invalid SVG makes me think about the can of 🪱s of invalid HTML more generally: HTML is generally tolerant of partial failures and will still "mostly work" even when elements aren't all in the right place. fabricate should follow this model, but enable optional validation should users desire it.

@respatialized respatialized self-assigned this Mar 19, 2022
@respatialized respatialized added this to the Sketch milestone Mar 19, 2022
@respatialized respatialized added the bug Something isn't working label Mar 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant