diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index 24d5efaf4e2..d84d7bf1025 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -18,7 +18,7 @@ What types of changes does your code introduce? Put an `x` in all the boxes that ## Checklist - [ ] Code contributed by me aligns with current project license: [Apache 2.0](https://www.apache.org/licenses/LICENSE-2.0) - - [ ] I Added [CHANGELOG](../CHANGELOG.md) entry regarding this change + - [ ] I Added [CHANGELOG](https://github.com/fabric8io/kubernetes-client/blob/master/CHANGELOG.md) entry regarding this change - [ ] I have implemented unit tests to cover my changes - [ ] I have added/updated the [javadocs](https://www.javadoc.io/doc/io.fabric8/kubernetes-client/latest/index.html) and other [documentation](https://github.com/fabric8io/kubernetes-client/blob/master/doc/CHEATSHEET.md) accordingly - [ ] No new bugs, code smells, etc. in [SonarCloud](https://sonarcloud.io/dashboard?id=fabric8io_kubernetes-client) report diff --git a/CHANGELOG.md b/CHANGELOG.md index 1bf65eb7dec..02a2a314ea2 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -8,6 +8,7 @@ * Fix #3582: SSL truststore can be loaded in FIPS enabled environments * Fix #3818: adding missing throws to launderThrowable * Fix #3859: refined how a deserialization class is chosen to not confuse types with the same kind +* Fix #3936: Kubernetes Mock Server .metadata.generation field is an integer #### Improvements * Fix #3811: Reintroduce `Replaceable` interface in `NonNamespaceOperation` diff --git a/kubernetes-server-mock/src/main/java/io/fabric8/kubernetes/client/server/mock/KubernetesCrudDispatcher.java b/kubernetes-server-mock/src/main/java/io/fabric8/kubernetes/client/server/mock/KubernetesCrudDispatcher.java index fd534cf0099..c8783ce5eb6 100644 --- a/kubernetes-server-mock/src/main/java/io/fabric8/kubernetes/client/server/mock/KubernetesCrudDispatcher.java +++ b/kubernetes-server-mock/src/main/java/io/fabric8/kubernetes/client/server/mock/KubernetesCrudDispatcher.java @@ -112,7 +112,7 @@ public MockResponse handleCreate(String path, String s) { /** * Replace the object on `path` endpoint with the object represented by `s` - * + * * @param path String * @param s String * @return The {@link MockResponse} @@ -470,7 +470,7 @@ private void setDefaultMetadata(JsonNode source, Map pathValues, metadata.put("namespace", pathValues.get(KubernetesAttributesExtractor.NAMESPACE)); } metadata.put("uid", getOrDefault(existingMetadata, "uid", uuid.toString())); - metadata.put(GENERATION, getOrDefault(existingMetadata, GENERATION, "1")); + metadata.put(GENERATION, Integer.parseInt(getOrDefault(existingMetadata, GENERATION, "1"))); metadata.put("creationTimestamp", getOrDefault(existingMetadata, "creationTimestamp", ZonedDateTime.now(ZoneOffset.UTC).format(DateTimeFormatter.ISO_INSTANT)));