Model has lombok.Setter when is not needed

[jorsol]

Describe the bug

Almost all the models are annotated with @Setter but the setters seem to be explicitly generated.

Fabric8 Kubernetes Client version

SNAPSHOT

Steps to reproduce

kubernetes-client/kubernetes-model-generator/kubernetes-model-core/src/generated/java/io/fabric8/kubernetes/api/model/Pod.java

Line 36 in 409be3b

@Setter

Expected behavior

The annotation should not be present when the setter is already generated:

kubernetes-client/kubernetes-model-generator/kubernetes-model-core/src/generated/java/io/fabric8/kubernetes/api/model/Pod.java

Line 106 in 409be3b

public void setApiVersion(String apiVersion) {

Runtime

other (please specify in additional context)

Kubernetes API Server version

1.25.3@latest

Environment

other (please specify in additional context)

Fabric8 Kubernetes Client Logs

No response

Additional context

This seems to be harmless and Lombok does not generate the setters if found one, but having one less annotation that does magical stuff is better.

[manusa]

Added in fix for #3570 in #3576 PR.

It's used to create the setAdditionalProperties method which is not included in the generated code by default.

We can do specific handling and add the additionalProperties setter ourselves using a custom rule.

[jorsol]

Well, if it's used to create the setAdditionalProperties then is ok to have it, yet it would be better to add the setter using a custom rule like you mention.

Honestly, if the toString, equals and hashCode can be also generated to remove lombok completely, that would be nice.

[manusa]

Well, if it's used to create the setAdditionalProperties then is ok to have it, yet it would be better to add the setter using a custom rule like you mention.

I opened #6102 to address this

Honestly, if the toString, equals and hashCode can be also generated to remove lombok completely, that would be nice.

I'm working on a replacement generator (#6080) to completely remove the Go-to-JSONSchema and the JSONSchema-to-Java code generation steps.
Once this is in place, it will be really easy to modify the templates so that the code is generated without Lombok annotations or anything else we want to change.