-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Watch Connection leak when HTTP_GONE happens #1943
Comments
need help? |
Actually we removed it in past, but it caused some unwanted regressions( see #1800 for more details) |
@rohanKanojia I encountered a similar issue when using shared informers. How to reproduce:
Is it possible to let shared informer detect such issue and start a re-list? Or there is some other workaround that can let client detect such error? #1075 (comment) seems like a dirty workaround that's probably not desirable.
|
@kolorful : Thanks for your report. I think we can add code to handle it on SharedInformer side when 410 occurs. |
Thank you! I'm using v4.6.3 and the error comes from this line: Line 279 in b595e42
I think it somehow mistakens Status as CRD and fall into the wrong logic block. Line 259 in b595e42
|
The other issue I observe is that informer's hasSynced() always returns true even after re-sync period is passed and re-sync failed. How to reproduce:
What I expect: re-list should fail due to kube-apiserver unavailable and hasSynced() returns false. Is this expected behaviour? It seems like in client-go you can pass a stop channel to the informer and if anything went wrong client can catch that and try restarting the informers, but we don't have that ability in java yet. |
@kolorful : Hmm, I see. I think we should file a separate issue for this use case. WDYT? I'll try to fix these before cutting 4.7.1 |
yes, I filed #1961 and thank you! |
This issue has been automatically marked as stale because it has not had any activity since 90 days. It will be closed if no further activity occurs within 7 days. Thank you for your contributions! |
This issue has been automatically marked as stale because it has not had any activity since 90 days. It will be closed if no further activity occurs within 7 days. Thank you for your contributions! |
When HTTP_GONE happens("too old resource version exception"), the web socket set to null first, the close function can not close the connection;
The code is in:
File : kubernetes-client/src/main/java/io/fabric8/kubernetes/client/dsl/internal/WatchConnectionManager.java
Line : 260
line:260 should be deleted?
The text was updated successfully, but these errors were encountered: