This repository has been archived by the owner on Jun 19, 2024. It is now read-only.
Display exception cause if possible #1769
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1769 +/- ##
============================================
+ Coverage 35.41% 35.41% +<.01%
Complexity 1173 1173
============================================
Files 191 191
Lines 10950 10952 +2
Branches 1776 1778 +2
============================================
+ Hits 3878 3879 +1
Misses 6608 6608
- Partials 464 465 +1 |
rohanKanojia
added
the
pr/changelog-entry-please
manusa
reviewed
Dec 13, 2019
| @@ -296,7 +296,11 @@ protected void buildAndTag(ServiceHub hub, ImageConfiguration imageConfig) | |||
| fabric8ServiceHub.getBuildService().build(imageConfig); | |||
|
|
|||
| } catch (Exception ex) { | |||
| throw new MojoExecutionException("Failed to execute the build: " + ex); | |||
| if (ex.getCause() != null) { | |||
There was a problem hiding this comment.
nit: more readable one-liner:
throw new MojoExecutionException("Failed to execute the build: " +
Optional.ofNullable(ex.getCause()).orElse(ex));
rohanKanojia
approved these changes
Dec 13, 2019
|
@plord12 : Could you please add a line to CHANGELOG.md regarding this change? |
oscerd
approved these changes
Dec 13, 2019
I tried but github wouldn't create the pull request. |
rohanKanojia
removed
the
pr/changelog-entry-please
|
@manusa : Shall we merge this too? |
|
@rohanKanojia Yep, sorry my mailbox got flooded (again) and this one got lost |
manusa
approved these changes
Jan 14, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1768