This repository has been archived by the owner on Jun 19, 2024. It is now read-only.
Changed Ingress resource kind from BUILD to INGRESS. fabric8:resource (#1631) #1728
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@nkkarthik :Thanks, Could you also please add a line to changelog regarding this change? |
rohanKanojia
added
the
pr/changelog-entry-please
|
How do I add a changelog entry? |
|
There is a file CHANGELOG.md in repository. You need to add a line regarding your change in 4.3-SNAPSHOT section |
Codecov Report
@@ Coverage Diff @@
## master #1728 +/- ##
=========================================
Coverage 34.32% 34.32%
Complexity 1116 1116
=========================================
Files 190 190
Lines 10794 10794
Branches 1753 1753
=========================================
Hits 3705 3705
Misses 6658 6658
Partials 431 431 |
|
Thank you, @rohanKanojia (I thought the file is autogenerated). Added an entry to the changelog file. |
devang-gaur
approved these changes
Oct 10, 2019
rohanKanojia
approved these changes
Oct 10, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.