This repository has been archived by the owner on Jun 19, 2024. It is now read-only.
Fix AutoTLSEnricher for Service Serving Certificate Secrets #1719
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Seems like we missed this during enricher refactoring, added the code for adding service.alpha.openshift.io/serving-cert-secret-name annotation
rohanKanojia
force-pushed
the
pr/fix-autotls-annotation
branch
from
9ed8fcb
to
18c0a85
Compare
rohanKanojia
added
the
jkube/pending
devang-gaur
approved these changes
Oct 4, 2019
rohanKanojia
added a commit
to rohanKanojia/jkube
that referenced
this pull request
Nov 7, 2019
rohanKanojia
removed
the
jkube/pending
rohanKanojia
added a commit
to eclipse-jkube/jkube
that referenced
this pull request
Nov 29, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seems like we missed this during enricher refactoring, added the code
for adding service.alpha.openshift.io/serving-cert-secret-name annotation
Thanks to @mojsha for noticing this!