Skip to content
This repository has been archived by the owner on Jun 19, 2024. It is now read-only.

Changes the timestamp tag to latest for Docker Images #1270

Merged
merged 3 commits into from
Aug 2, 2018

Conversation

piyush-garg
Copy link
Collaborator

@piyush-garg piyush-garg commented Apr 12, 2018

This will fix the FMP goals broken
Fixes #1093

…g images

This will fix the different invocations broken like fabric8:build fabric8:resource and hitting invocations separately like
fabric8:resource and then fabric8:build
This will also fix the problem of generating excessive docker images
fabric8io#1093
@hrishin
Copy link
Member

hrishin commented Jun 15, 2018

@piyush1594 could you please fix this? You may like update CHANGELOG.md as well.

@rohanKanojia rohanKanojia added the target/4.0 PR for targeted to 4.0.x label Jul 24, 2018
@rhuss
Copy link
Contributor

rhuss commented Jul 30, 2018

Looks good !

As I'm going to create the 3.5 branch tomorrow, lets hold back all 4.0 PRs for now. That will make my life easier ;-) After this (and when we resolved the conflict), we should be fine.

@rhuss rhuss changed the title Fix 1093 Changes the timestamp tag to latest for Docker Images Changes the timestamp tag to latest for Docker Images Jul 30, 2018
@rhuss
Copy link
Contributor

rhuss commented Aug 2, 2018

@rohanKanojia a booster check seems to be constantly failing:

Results :
Tests in error: 
  VertxHealthchecksBoosterIT.redeploy_vertx_app:80->assertDeployment:101->testHealthChecks:119->assertApplicationRecovery:131->BaseBoosterIT.makeHttpRequest:273 » IO
Tests run: 12, Failures: 0, Errors: 1, Skipped: 0

as I can't see how this PR affects the test I'm going to merge it still.

@rhuss rhuss merged commit 607aa3a into fabric8io:master Aug 2, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
target/4.0 PR for targeted to 4.0.x
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Revert default image name back to "latest" for snapshots
5 participants