Skip to content
This repository has been archived by the owner on Jun 19, 2024. It is now read-only.

Remove 'abstract' qualifier from BaseEnricher #1586

Closed
devang-gaur opened this issue Mar 19, 2019 · 0 comments
Closed

Remove 'abstract' qualifier from BaseEnricher #1586

devang-gaur opened this issue Mar 19, 2019 · 0 comments
Labels
cat/starter Easy issue, ideally for starting with fabric-maven-plugin

Comments

@devang-gaur
Copy link
Contributor

BaseEnricher class doesn't have any abstract method. Therefore, the 'abstract` qualifier in the definition is a redundant and confusing piece of code.
@devang-gaur devang-gaur added the cat/starter Easy issue, ideally for starting with fabric-maven-plugin label Mar 19, 2019
This was referenced Mar 23, 2019
Merged
Merged
kunal-kushwaha added a commit to kunal-kushwaha/fabric8-maven-plugin that referenced this issue Mar 25, 2019
@kunal-kushwaha
Fix added in CHANGELOG.md regarding issue fabric8io#1586
d9e749e
devang-gaur pushed a commit that referenced this issue Mar 25, 2019
@kunal-kushwaha
'abstract' qualifier in BaseEnricher class removed (#1596)
5115b33 
* WatchEnricher file removed

* abstract'qualifier removed from BaseEnricher

* Fix added in CHANGELOG.md regarding issue #1586
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
cat/starter Easy issue, ideally for starting with fabric-maven-plugin
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@devang-gaur