Skip to content
This repository has been archived by the owner on Jun 19, 2024. It is now read-only.

Support for from Image configuration in openshift docker build strategy #1458

Closed
bohmber opened this issue Dec 18, 2018 · 0 comments
Closed

Support for from Image configuration in openshift docker build strategy #1458

bohmber opened this issue Dec 18, 2018 · 0 comments
Assignees
@bohmber

Comments

@bohmber
Copy link
Contributor

bohmber commented Dec 18, 2018 •
edited
Loading

It would be nice to configure the from image of the dockerStrategy via fromExt, from and dockerFile property.

  • f-m-p: 4.0.0-M2
  • Maven: 3.5.x
  • OpenShift: 3.7.x
bohmber added a commit to bohmber/fabric8-maven-plugin that referenced this issue Dec 18, 2018
@bohmber
Support fromExt configuration in openshift docker build strategy fabr…
d9e8cc6 
…ic8io#1458

Signed-off-by: bohmber <[email protected]>
bohmber added a commit to bohmber/fabric8-maven-plugin that referenced this issue Dec 18, 2018
@bohmber
Support from configuration in openshift docker build strategy fabric8…
c70283c 
…io#1458

Now it looks similar s2i and should cover more usecases

Signed-off-by: bohmber <[email protected]>
bohmber added a commit to bohmber/fabric8-maven-plugin that referenced this issue Dec 18, 2018
@bohmber
Support from configuration in openshift docker build strategy fabric8…
01eeca9 
…io#1458

fixed import

Signed-off-by: bohmber <[email protected]>
@bohmber bohmber changed the title Support fromExt configuration in openshift docker build strategy Support from configuration in openshift docker build strategy Dec 18, 2018
@bohmber bohmber mentioned this issue Dec 18, 2018
Merged
@bohmber bohmber changed the title Support from configuration in openshift docker build strategy Support from Image configuration in openshift docker build strategy Dec 18, 2018
bohmber added a commit to bohmber/fabric8-maven-plugin that referenced this issue Dec 18, 2018
@bohmber
Support for from configuration in openshift docker build strategy fab…
76a78ce 
…ric8io#1458

added changelog

Signed-off-by: bohmber <[email protected]>
@bohmber bohmber changed the title Support from Image configuration in openshift docker build strategy Support for from Image configuration in openshift docker build strategy Dec 18, 2018
bohmber added a commit to bohmber/fabric8-maven-plugin that referenced this issue Dec 26, 2018
@bohmber
Support for from configuration in openshift docker build strategy fab…
43be540 
…ric8io#1458

added unit test

Signed-off-by: bohmber <[email protected]>
bohmber added a commit to bohmber/fabric8-maven-plugin that referenced this issue Dec 26, 2018
@bohmber
Support for from configuration in openshift docker build strategy fab…
84fe1cb 
…ric8io#1458

improved unit test

Signed-off-by: bohmber <[email protected]>
lordofthejars pushed a commit that referenced this issue Dec 28, 2018
@bohmber @lordofthejars
Support from Image configuration in openshift docker build strategy #…
4bf15bf 
…1458 (#1459)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bohmber bohmber

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bohmber