fix(#690): Removes deprecated legacyPortMapping configuration property

CHANGELOG.md

@@ -15,6 +15,7 @@ After this we will switch probably to real [Semantic Versioning 2.0.0](http://se
 * Feature 729: Select custom resources depending on environment.
 * Feature 601: Adds healthcheck for webapp
 * Fix 1460: Upgraded kubernetes client to 4.1.1
+* Fix 690: Removes deprecated _legacyPortMapping_ property.
 
 ### 4.0.0-M2 (2018-12-14)
 * Fix 10: Make VolumeConfiguration more flexible

doc/src/main/asciidoc/inc/enricher/_fmp_service.adoc

@@ -42,10 +42,6 @@ The following configuration parameters can be used to influence the behaviour of
 | *protocol*
 | Default protocol to use for the services. Must be `tcp` or `udp`
 | `tcp`
-
-| *legacyPortMapping*
-| If this mapping options is set to `true` then a pod exports ports 8080 or 9090 is mapped to a service port 80. This is deprecated and switched off by default. You can switch it on to get back the old behaviour or, even better, use `port` for setting the service port directly.
-| `false`
 |===
 
 You specify the properties like for any enricher within the enrichers configuration like in

enricher/standard/src/main/java/io/fabric8/maven/enricher/standard/DefaultServiceEnricher.java

@@ -82,9 +82,6 @@ private enum Config implements Configs.Key {
         // Service port to use (only for the first exposed pod port)
         port,
 
-        // Legacy mapping from port 8080 / 9090 to 80
-        legacyPortMapping {{ d = "false"; }},
-
         // Whether to expose multiple ports or only the first one
         multiPort {{ d = "false"; }},
 
@@ -360,10 +357,6 @@ private ServicePort updateMissingTargetPort(ServicePort port, Integer targetPort
     }
 
     private int checkForLegacyMapping(int port) {
-        // The legacy mapping maps 8080 -> 80 and 9090 -> 90 which needs to be enabled explicitly
-        if (Configs.asBoolean(getConfig(Config.legacyPortMapping)) && (port == 8080 || port == 9090)) {
-            return 80;
-        }
         return port;
     }