fixed plugin can not find assembly descriptor #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Awesome. Thanks a lot for the fix. Could you please do me a favor and sign-off your commits as explained here ? Please also for you other PRs which I'm going to integrate today. You simply need to do a on this bug fix branch (works for the last commit, if you need to sign-off more commits in retrospective, you need an interactive rebase (git -i rebase)) Thanks a lot ! |
|
do you want to do a quick bugfix release w/ these and maybe slate new functionality for 0.12.0? |
|
Yes, think this is a good idea. I will do a a 0.11.2 this weekend. |
|
was there a 0.11.1 that i missed? |
|
Ehm, no. I was wrong, no 0.11.1 yet, so that's the next one. |
… started from top module Signed-off-by: Peter Leibiger <[email protected]>
kuhnroyal
force-pushed
the
fixedBaseDir
branch
from
be00aef to
e276a03
Compare
rhuss
added a commit
that referenced
this pull request
Feb 10, 2015
|
Applied and available on branch |
leusonmario
pushed a commit
to leusonmario/docker-maven-plugin
that referenced
this pull request
Aug 18, 2018
leusonmario
pushed a commit
to leusonmario/docker-maven-plugin
that referenced
this pull request
Aug 18, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The plugin could not find the assembly.xml file in the default source directory in multi-module maven projects.
It works if docker:build is executed from the sub-module but not if execute from the parent module.
When building the absolute path to the assembly.xml or Dockerfile the project baseDir is now respected.