Preserve leading whitespace in logs #875
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes the log line match pattern to preserve leading whitespace in log lines by only consuming a single space delimiter between the timestamp and the message body. Signed-off-by: Scott Coplin <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #875 +/- ##
=========================================
Coverage 50.46% 50.46%
Complexity 1180 1180
=========================================
Files 137 137
Lines 7033 7033
Branches 935 935
=========================================
Hits 3549 3549
Misses 3177 3177
Partials 307 307
|
|
I'm not sure what the original reason for the \s+ pattern was in the log line matching, but looking at the docker api source code, it looks like it has used a single space to delimit timestamp from body for at least several years now, even through refactorings. I tracked it back at least as far as this commit: |
rhuss
approved these changes
Nov 3, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes the log line match pattern to preserve leading whitespace in log
lines by only consuming a single space delimiter between the timestamp
and the message body.
Signed-off-by: Scott Coplin [email protected]