#595 - Fix concurrency issue on log wait. #596
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks a lot. I'm currently on the road but will be back soon. Will check out the PR ASAP. |
|
You are absolutely correct, |
|
0.16.9 is out with fix applied |
|
Fantastic - thanks a lot! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed the synchronized because the
check()method will always performed by the same thread. The memberdetectedwas only partly covered by the original synchronized because it was written in an anonymous inner class (LogCallback) which was not part of the synchronized block.This fix mark the
detectedflag asvolatileto ensure that a write by an other thread calling the log callback will be propagate to the thread who calls thecheck()method.