Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support custom key for exposed container properties #557

Closed
jpraet opened this issue Sep 16, 2016 · 2 comments
Closed

support custom key for exposed container properties #557

jpraet opened this issue Sep 16, 2016 · 2 comments

Comments

@jpraet
Copy link
Contributor

jpraet commented Sep 16, 2016

Currently container properties such as ip are exposed as docker.container.<alias>.ip, e.g. docker.container.jboss.ip.

In my case the docker plugin configuration is located in a corporate parent pom. All our projects extend from this parent pom. Therefore, in the parent pom, the alias is assigned dynamically as <alias>jboss-${project.artifactId}-${project.version} with <namingStrategy>alias</namingStrategy>.

This means the container ip is exposed with name docker.container.jboss-${project.artifactId}-${project.version}.ip. I am not able to access this property easily, because the name is built dynamically.

It would be nice if I could configure something like <containerPropertyKey>jboss</containerPropertyKey> in the image run configuration in order to still have dynamic container names, but with static container property keys.

@rhuss
Copy link
Collaborator

rhuss commented Oct 7, 2016

Yeah, makes sense. Let me check how we can put it into the configuration.

@rhuss rhuss closed this as completed in 8c307e4 Oct 7, 2016
@jpraet
Copy link
Contributor Author

jpraet commented Oct 11, 2016

Thanks! I tried to test out the new exposedPropertyKey configuration, but ran into another issue when upgrading: #583

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants