-
Notifications
You must be signed in to change notification settings - Fork 644
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resolved images are cached even if <image> configuration changes between executions #495
Comments
I'm just about to remove the caching for the next release. It wasn't such a good idea (also because of classloader issues I had lately). That will be in the next release, which will probably released today. |
👏 👌 |
Fixed in 0.15.8 |
Thanks for fixing this! |
Actually, it only passed because I had commented out the build in my second module. 😢 I have a parent project with two modules, let's call them A and B. However, when B is telling me it's building an image, it's telling me it's building a but shoves b's content in there. This sounds like the bug you fixed, but seems to be happening with 0.15.9. Is there something I'm missing? |
can you post your poms? |
I don't know if I'm legally able to do that as it's for my company. Is there anything in particular that I should look for in the configuration arrangement of my docker plugin sections? |
For demonstration, this is the build portion of the first module and the build portion of the second module. It's pretty clear from the target paths and image names that the wires are crossed.
|
yeah - there is something off but w/o being able to see the relevant potions of the poms... i think you'd be ok if you just substituted any company specific information w/ something generic. |
When executing more than one goal with different values for the
<image>
configuration, the first<image>
configuration is used to resolve images. The result is stored inside the plugin context. The next execution may potentially have a different configuration for<image>
, but won't re-resolve images, but reuse the resolved images that have been stored in the plugin context. Hence it will operate on the wrong set of resolved images.The text was updated successfully, but these errors were encountered: