Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use of "--shm-size" as "docker run" parameter #463

Closed
obigard opened this issue Jun 2, 2016 · 6 comments
Closed

Use of "--shm-size" as "docker run" parameter #463

obigard opened this issue Jun 2, 2016 · 6 comments
Labels

Comments

@obigard
Copy link
Contributor

obigard commented Jun 2, 2016

Hello,

Is there a way to add the "--shm-size" parameter in the "docker run" command produced by the plugin?
This parameter is a standard one, as described in Docker reference documentation

Thanks,
Olivier

@rhuss
Copy link
Collaborator

rhuss commented Jun 2, 2016

No, not yet. But it should be easy to add. If you feel fancy, please create a PR. Its easy to implement, a starting point is e.g. https://github.com/fabric8io/docker-maven-plugin/blob/master/src/main/java/io/fabric8/maven/docker/access/ContainerCreateConfig.java#L102 where the Memory options inserted. For shm its ShmSize

If not, no problem. I put this on the roadmap (but might take a bit)

@rhuss rhuss added the feature label Jun 2, 2016
@obigard
Copy link
Contributor Author

obigard commented Jun 2, 2016

I'll try to do it!

@rhuss
Copy link
Collaborator

rhuss commented Jun 2, 2016

cool, thx :)

@obigard
Copy link
Contributor Author

obigard commented Jun 2, 2016

done!

@obigard
Copy link
Contributor Author

obigard commented Jun 2, 2016

#464

@rhuss
Copy link
Collaborator

rhuss commented Jun 3, 2016

Thanks. 0.15.4 is released, containing your fixes.

@rhuss rhuss closed this as completed Jun 3, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants